Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Prev Previous commit
more tranistive deps
  • Loading branch information
Elliotte Rusty Harold committed Jan 29, 2021
commit 1c96f6448e7713709673a7275328330abf8420b4
16 changes: 13 additions & 3 deletions dependencies.properties
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,23 @@ maven.io_opencensus_opencensus_api=io.opencensus:opencensus-api:0.24.0
maven.io_opencensus_opencensus_contrib_grpc_metrics=io.opencensus:opencensus-contrib-grpc-metrics:0.24.0
maven.io_opencensus_opencensus_contrib_http_util=io.opencensus:opencensus-contrib-http-util:0.24.0
maven.io_netty_netty_tcnative_boringssl_static=io.netty:netty-tcnative-boringssl-static:2.0.36.Final

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can anyone explain why this upgrade requires me to add all these transitive dependencies from gRPC? Something about bazel builds I'm missing? @ejona86

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you aren't using mvn_install: https://github.com/googleapis/gax-java/blob/master/WORKSPACE

https://github.com/grpc/grpc-java/releases/tag/v1.33.0

bazel: Remove Maven repositories from repositories.bzl, in favor of maven_install. v1.27.0 introduced support for maven_install and encouraged users to migrate. See examples/WORKSPACE for an example. maven_install dramatically reduces the boilerplate for maven dependencies and properly handles transitive dependencies and version selection. gRPC is not yet using the @maven workspace, so it is still possible to use other dependency tools.

https://github.com/grpc/grpc-java/releases/tag/v1.27.0

Bazel users should migrate to maven_install. Please open an issue to report problems migrating to maven_install.

bazel: Support maven_install (#6553). See examples/WORKSPACE for typical usage. grpc-java still supports the jvm_maven_import_external()-based loading only to ease migration. grpc-java will drop usages of jvm_maven_import_external() in the future

maven.io_netty_netty_handler=io.netty:netty-handler:4.1.58.Final
maven.io_netty_netty_common=io.netty:netty-common:4.1.58.Final
maven.io_netty_netty_transport=io.netty:netty-transport:4.1.58.Final
maven.io_netty_netty_handler=io.netty:netty-handler:4.1.52.Final
maven.io_netty_netty_common=io.netty:netty-common:4.1.52.Final
maven.io_netty_netty_codec_socks=io.netty:netty-codec-socks:4.1.52.Final
maven.io_netty_netty_codec_http2=io.netty:netty-codec-http2:4.1.52.Final
maven.io_netty_netty_codec_http=io.netty:netty-codec-http:4.1.52.Final
maven.io_netty_netty_codec=io.netty:netty-codec:4.1.52.Final
maven.io_netty_netty_buffer=io.netty:netty-buffer:4.1.52.Final
maven.io_netty_netty_resolver=io.netty:netty-resolver:4.1.52.Final
maven.io_netty_netty_transport=io.netty:netty-transport:4.1.52.Final
maven.io_netty_netty_handler_proxy=io.netty:netty-handler-proxy:4.1.52.Final
maven.io_perfmark_perfmark_api=io.perfmark:perfmark-api:0.23.0
maven.org_apache_tomcat_annotations_api=org.apache.tomcat:annotations-api:6.0.53
maven.com_google_code_gson_gson=com.google.code.gson:gson:2.8.6
maven.com_google_guava_guava=com.google.guava:guava:30.1-android
maven.com_google_guava_failureaccess=com.google.guava:failureaccess:1.0.1
maven.org_apache_commons_commons_lang3=org.apache.commons:commons-lang3:3.8.1
maven.com_google_android_annotations=com.google.android:annotations:4.1.1.4
maven.com_google_code_findbugs_jsr305=com.google.code.findbugs:jsr305:3.0.2
maven.com_google_errorprone_error_prone_annotations=com.google.errorprone:error_prone_annotations:2.5.1
maven.com_google_j2objc_j2objc_annotations=com.google.j2objc:j2objc-annotations:1.3
Expand Down