feat!: integrates external_accounts with `GoogleAuth` and ADC by bojeil-google · Pull Request #1052 · googleapis/google-auth-library-nodejs

bojeil-google · 2020-09-03T08:05:57Z

Exports IdentityPoolClient, IdentityPoolClientOptions, AwsClient, AwsClientOptions, ExternalAccountClient and ExternalAccountClientOptions.

Defines CredentialsClient interface as the root interface for all clients that generate credentials. Updates AuthClient to implement that interface. All existing clients extend AuthClient and already conform to CredentialsClient.

Exposes eagerRefreshThresholdMillis and forceRefreshOnFailure on BaseExternalAccountClient as they are exposed on all clients which inherit from OAuth2Client and AuthClient.

Defines JSONClient in GoogleAuth for all credentials that can be initialized from JSON objects (as part of ADC): JWT | UserRefreshClient | BaseExternalAccountClient. This excludes Compute clients.

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5f7f9c6d-c75a-4c60-8bb8-0026a14cead7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@94421c4

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/b742586e-df31-4aac-8092-78288e9ea8e7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@bd0deaa

This PR was generated using Autosynth. 🌈 - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5747555

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Minor change that fixes a spelling error. I don't think an issue needed to be opened for this. Thanks!

Add await Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7a1b0b96-8ddb-4836-a1a2-d2f73b7e6ffe/targets - [ ] To automatically regenerate this PR, check this box.

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/ba2d388f-b3b2-4ad7-a163-0c6b4d86894f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@05de3e1

…1048) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/96acae41-dfd7-4d71-95d3-12436053b826/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@8cf6d28

codecov · 2020-09-03T08:06:03Z

Codecov Report

❗ No coverage uploaded for pull request base (byoid@d759b09). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             byoid    #1052   +/-   ##
========================================
  Coverage         ?   91.52%           
========================================
  Files            ?       21           
  Lines            ?     4093           
  Branches         ?      454           
========================================
  Hits             ?     3746           
  Misses           ?      347           
  Partials         ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d759b09...9ec8bea. Read the comment docs.

google-cla · 2020-09-03T08:06:10Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

bcoe

I believe this will break the upstream:

https://github.com/googleapis/nodejs-googleapis-common/blob/master/src/authplus.ts

Which wraps GoogleAuth, I suggest we release this work as a breaking change, just so we can make the update intentional for upstream consumers.

The upstream consumers need not take this as a breaking change.

bcoe · 2020-09-03T21:57:05Z

 import {
  BaseExternalAccountClient,
-  BaseExternalAccountClientOptions,
  EXTERNAL_ACCOUNT_TYPE,


because of the suffix type I thought this would be an interface or type, I would add a comment:

// this string constant indicates that external account should be instantiated ?

Done. I added clarification here and in baseexternalclient.ts where it is declared.

google-cla · 2020-09-03T23:00:55Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

bojeil-google · 2020-09-03T23:04:56Z

Sounds good on the breaking change. I think we can help make the necessary changes in nodejs-googleapis-common. We want to make sure all clients are able benefit from this feature.

feat: implements the OAuth token exchange spec based on rfc8693 (#1026) feat: defines ExternalAccountClient abstract class for external_account credentials (#1030) feat: adds service account impersonation to `ExternalAccountClient` (#1041) feat: defines `IdentityPoolClient` used for K8s and Azure workloads (#1042) feat: implements AWS signature version 4 for signing requests (#1047) feat: defines `ExternalAccountClient` used to instantiate external account clients (#1050) feat!: integrates external_accounts with `GoogleAuth` and ADC (#1052) feat: adds text/json credential_source support to IdentityPoolClients (#1059) feat: get AWS region from environment variable (#1067) Co-authored-by: Wilfred van der Deijl <wilfred@vanderdeijl.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

grayside and others added 15 commits August 7, 2020 16:32

refactor(samples): idtoken-cloudrun => idtoken-serverless (#1025)

11b0cb7

docs: README updated with new sample paths

4df48df

chore: release 6.0.7 (#1023)

6dfee1d

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

fix(deps): roll back dependency google-auth-library to ^6.0.6 (#1033)

eb54ee9

build: perform publish using Node 12 (#1035)

714247d

This PR was generated using Autosynth. 🌈 - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5747555

chore: release 6.0.8 (#1036)

211e042

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

docs: correct spelling of its (#1040)

d4e56c0

Minor change that fixes a spelling error. I don't think an issue needed to be opened for this. Thanks!

docs: fix usage in readme (#1031)

6c15139

Add await Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

chore: start tracking obsolete files (#1043)

0c8e086

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/7a1b0b96-8ddb-4836-a1a2-d2f73b7e6ffe/targets - [ ] To automatically regenerate this PR, check this box.

Merge remote-tracking branch 'upstream/byoid'

d8be414

feat: integrates external_accounts with GoogleAuth and ADC

4d38e98

bojeil-google requested a review from a team September 3, 2020 08:05

blunderbuss-gcf Bot assigned sofisl Sep 3, 2020

google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 3, 2020

bcoe changed the title ~~feat: integrates external_accounts with GoogleAuth and ADC~~ feat!: integrates external_accounts with GoogleAuth and ADC Sep 3, 2020

bcoe suggested changes Sep 3, 2020

View reviewed changes

Clarifies EXTERNAL_ACCOUNT_TYPE constant.

9ec8bea

bcoe added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2020

google-cla Bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Sep 9, 2020

bcoe approved these changes Sep 9, 2020

View reviewed changes

bcoe merged commit 291652a into googleapis:byoid Sep 9, 2020

release-please Bot mentioned this pull request Feb 6, 2021

chore: release 7.0.0 #1135

Merged

leandro-manifesto mentioned this pull request Feb 23, 2021

Auth: Export AuthClient #1145

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat!: integrates external_accounts with `GoogleAuth` and ADC#1052

feat!: integrates external_accounts with `GoogleAuth` and ADC#1052
bcoe merged 16 commits into
googleapis:byoidfrom
bojeil-google:google-auth-external-client

bojeil-google commented Sep 3, 2020

Uh oh!

codecov Bot commented Sep 3, 2020 •

edited

Loading

Uh oh!

google-cla Bot commented Sep 3, 2020

Uh oh!

bcoe left a comment

Uh oh!

bcoe Sep 3, 2020

Uh oh!

bojeil-google Sep 3, 2020

Uh oh!

google-cla Bot commented Sep 3, 2020

Uh oh!

bojeil-google commented Sep 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

bojeil-google commented Sep 3, 2020

Uh oh!

codecov Bot commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

google-cla Bot commented Sep 3, 2020

Uh oh!

bcoe left a comment

Choose a reason for hiding this comment

Uh oh!

bcoe Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

bojeil-google Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

google-cla Bot commented Sep 3, 2020

Uh oh!

bojeil-google commented Sep 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov Bot commented Sep 3, 2020 •

edited

Loading