This repository was archived by the owner on Nov 20, 2025. It is now read-only.
fix: support PEM and p12 when using factory#1120
Merged
Merged
Conversation
added 2 commits
January 22, 2021 11:06
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
+ Coverage 91.62% 91.65% +0.02%
==========================================
Files 21 21
Lines 4145 4157 +12
Branches 461 464 +3
==========================================
+ Hits 3798 3810 +12
Misses 347 347
Continue to review full report at Codecov.
|
sofisl
approved these changes
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not handling PEM and P12 when using the
GoogleAuthfactory.Fixes #808