Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

ci: release=8 for JDK 9+ #478

Merged
suztomo merged 2 commits into from
Jun 10, 2022
Merged

ci: release=8 for JDK 9+ #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bf1a29
ci: release=8 for JDK 9+
suztomo Jun 3, 2022
0dba226
ci: removing "dependencies (8)"
suztomo Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ branchProtectionRules:
requiresStrictStatusChecks: false
# List of required status check contexts that must pass for commits to be accepted to matching branches.
requiredStatusCheckContexts:
- "dependencies (8)"

@suztomo suztomo Jun 10, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a followup of #479

- "dependencies (11)"
- "lint"
- "clirr"
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/downstream-dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [8, 11]
java: [11]
repo:
- java-bigquery
- java-bigqueryconnection
Expand All @@ -27,5 +27,3 @@ jobs:
- run: sudo apt-get update -y
- run: sudo apt-get install libxml2-utils
- run: .kokoro/client-library-check.sh ${{matrix.repo}} dependencies
if: ${{matrix.java != '8' }}
# Always successful for Java 8, which we'll remove soon
13 changes: 12 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,6 +833,17 @@
</plugins>
</build>
</profile>

<profile>
<!-- JDK 9+ has the "release" option to ensure the generated bytecode is
compatible with Java 8. Maven-compiler-plugin's "<target>1.8</target>" is
not sufficient. -->
<id>compiler-release-8</id>
<activation>
<jdk>[9,]</jdk>
</activation>
<properties>
<maven.compiler.release>8</maven.compiler.release>
</properties>
</profile>
</profiles>
</project>