Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

refactor: clean up unused packages#517

Merged
JustinBeckwith merged 2 commits into
googleapis:masterfrom
JustinBeckwith:cu
Mar 3, 2019
Merged

refactor: clean up unused packages#517
JustinBeckwith merged 2 commits into
googleapis:masterfrom
JustinBeckwith:cu

Conversation

@JustinBeckwith

Copy link
Copy Markdown
Contributor

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2019

@callmehiphop callmehiphop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry if I murdered your other PR :<

Comment thread system-test/pubsub.ts Outdated
@codecov

codecov Bot commented Mar 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #517 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files          16       16           
  Lines         996      996           
  Branches       87       87           
=======================================
  Hits          946      946           
  Misses         42       42           
  Partials        8        8
Impacted Files Coverage Δ
src/message-stream.ts 100% <ø> (ø) ⬆️
src/topic.ts 91.66% <100%> (ø) ⬆️
src/publisher.ts 100% <100%> (ø) ⬆️
src/subscription.ts 100% <100%> (ø) ⬆️
src/iam.ts 100% <100%> (ø) ⬆️
src/pubsub.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f3147...f8d870a. Read the comment docs.

@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 3, 2019
@JustinBeckwith
JustinBeckwith merged commit d5806be into googleapis:master Mar 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants