Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

revert!: remove pullTimeout subscriber option#618

Merged
callmehiphop merged 2 commits into
googleapis:masterfrom
callmehiphop:revert-556
May 20, 2019
Merged

revert!: remove pullTimeout subscriber option#618
callmehiphop merged 2 commits into
googleapis:masterfrom
callmehiphop:revert-556

Conversation

@callmehiphop

@callmehiphop callmehiphop commented May 20, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Relates to #468 (comment)

The PubSub team would prefer that we do not provide this option.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2019
@callmehiphop
callmehiphop requested review from bcoe and sduskis May 20, 2019 15:32
@codecov

codecov Bot commented May 20, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          14       14           
  Lines         857      857           
  Branches      178      178           
=======================================
  Hits          839      839           
  Misses          2        2           
  Partials       16       16
Impacted Files Coverage Δ
src/message-stream.ts 97.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eedf0f...3a3f783. Read the comment docs.

bcoe
bcoe approved these changes May 20, 2019
View reviewed changes

@bcoe bcoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Do I gather that pullTimeout was added in an attempt to address a specific user's problem, and it ultimately wasn't needed?

@callmehiphop

callmehiphop commented May 20, 2019

Copy link
Copy Markdown
Contributor Author

@bcoe yeah, that is pretty much the gist of why

@callmehiphop
callmehiphop merged commit 4fc9724 into googleapis:master May 20, 2019
@yoshi-automation yoshi-automation mentioned this pull request May 20, 2019
Closed
@yoshi-automation yoshi-automation mentioned this pull request May 28, 2019
Closed
@yoshi-automation yoshi-automation mentioned this pull request Jun 5, 2019
Closed
@callmehiphop callmehiphop mentioned this pull request Jun 17, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
This was referenced Apr 29, 2020
Closed
Closed
@feywind feywind mentioned this pull request May 20, 2020
Closed
@release-please release-please Bot mentioned this pull request May 20, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sduskis sduskis Awaiting requested review from sduskis
1 more reviewer
@bcoe bcoe bcoe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@callmehiphop @bcoe @googlebot @JustinBeckwith