This repository was archived by the owner on Mar 17, 2026. It is now read-only.
build: adding benchmarking script#778
Merged
Merged
Conversation
callmehiphop
reviewed
Oct 9, 2019
callmehiphop
left a comment
Contributor
There was a problem hiding this comment.
LGTM, might need to run an npm run fix to appease the linter
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
- Coverage 96.77% 94.49% -2.29%
==========================================
Files 14 15 +1
Lines 869 890 +21
Branches 182 182
==========================================
Hits 841 841
- Misses 7 28 +21
Partials 21 21
Continue to review full report at Codecov.
|
bcoe
approved these changes
Oct 14, 2019
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/b205fd33-200c-4298-88b8-18b0d1c79a3e/targets - [ ] To automatically regenerate this PR, check this box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a gRPC server which wraps the pubsub client library, specifically testing streaming pull. A load testing framework can hit the gRPC server defined here to test the latency of our client library, which simply acks messages as they come in.
This requires the removal of grpc.OK as a retryable error, which is not currently used per #776 (comment).
For reference: benchmark wrapper for the storage lib: googleapis/nodejs-storage#788.
Fixes #776 🦕