Skip to content

fetch proxy from bootstrap#1242

Merged
neonphog merged 11 commits into
developfrom
use-bootstrap-proxy-list
Feb 25, 2022
Merged

fetch proxy from bootstrap#1242
neonphog merged 11 commits into
developfrom
use-bootstrap-proxy-list

Conversation

@neonphog

@neonphog neonphog commented Feb 21, 2022

Copy link
Copy Markdown
Collaborator

DEPENDS ON #1236

Summary

  • actually makes use of the network proxy config to fetch proxy server from the bootstrap service.

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

@neonphog neonphog added the NO-MERGE (dependency) This PR depends on another - and does not point to "develop". label Feb 21, 2022
@neonphog neonphog changed the title WIP: fetch proxy from bootstrap fetch proxy from bootstrap Feb 22, 2022
@neonphog neonphog marked this pull request as ready for review February 22, 2022 22:30
@neonphog neonphog requested review from freesig, maackle and thedavidmeister and removed request for thedavidmeister February 22, 2022 22:30

@freesig freesig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Base automatically changed from bootstrap-proxy-list to develop February 23, 2022 21:56

@steveej steveej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only came here to check out the dev-dependency declaration 😉

Comment thread crates/kitsune_p2p/kitsune_p2p/Cargo.toml Outdated
neonphog and others added 2 commits February 24, 2022 10:20
Co-authored-by: Stefan Junker <1181362+steveeJ@users.noreply.github.com>
Comment thread crates/holochain/CHANGELOG.md Outdated
Co-authored-by: Stefan Junker <1181362+steveeJ@users.noreply.github.com>
@neonphog neonphog merged commit 4f34ad6 into develop Feb 25, 2022
@neonphog neonphog deleted the use-bootstrap-proxy-list branch February 25, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO-MERGE (dependency) This PR depends on another - and does not point to "develop".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants