Review: fix infinite loop on persistent skill catalog errors

Conclusion: Approve. This is a correct, minimal fix for a real infinite-loop bug.

Why the loop happened

The useEffect in App.tsx:212 re-fires refreshSkillCatalog() whenever skillCatalog.source === "fixture" and the skills route is active. The initial state (emptySkillCatalog) has source: "fixture". Before this fix, the catch block spread ...state.skillCatalog without overriding source, so on a persistent HTTP error the catalog stayed at source: "fixture", and the effect re-triggered indefinitely.

Setting source: "http" in the catch block correctly breaks the loop — the effect guard (source !== "fixture") stops re-firing.

Verification

• The useEffect dependency array includes skillCatalog.source, so the transition from "fixture" to "http" is observed and prevents re-execution.
• This matches the existing convention in refreshSkillDetail's catch block (line 943), which already sets { source: "http", error: message }.

Non-blocking observation (nit)

The catch blocks for addSkillToCatalog, removeSkillFromCatalog, updateSkillCatalog, and checkSkillCatalog (~lines 961, 979, 997, 1015) also spread state.skillCatalog without overriding source. These are not affected by the same loop today because they are user-initiated actions (not guarded by the useEffect) and return false on error. For consistency and defense against future effect-driven refetch logic, consider applying the same source: "http" override there as a follow-up.

Holon Run Report

• Result: completed
• Target: fix: set source to http in refreshSkillCatalog catch block to prevent… #2014
• Workflow run: https://github.com/holon-run/holon/actions/runs/28210235112
• Model: bigmodel/glm-5.2
• Requested model: bigmodel/glm-5.2
• Fallback active: false
• Token usage: input 22376, output 3749, total 26125
• Provider cache: read 364544, created 0, cacheable 364544, hit rate 100%
• Model rounds: 17
• Tool calls: 24