feat: add agent template tui flows#2113
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Holon Review: feat: add agent template tui flows
Conclusion: Solid feature addition that follows existing TUI patterns. Two minor findings — one coupling risk and one dead-code-path nit. No correctness, security, or performance issues.
Findings
[warn] TemplateUrlInput reuses DebugPromptInput key context (src/tui/view_model.rs:185)
TemplateUrlInput is mapped to KeyContext::DebugPromptInput, coupling two semantically unrelated overlays. If debug-prompt keybindings are customized later, template URL input inherits those changes unintentionally. Consider adding a dedicated KeyContext::TemplateUrlInput variant.
[nit] OverlayAccept in Manage mode is a silent no-op (src/tui/input.rs:2383)
Pressing Enter in Manage mode rebuilds the same overlay state without any user-visible effect. Consider adding a status-line message or falling through to the catch-all branch.
Positive notes
- Clean delegation:
create_agent→create_agent_with_templatemaintains backward compat. - Template catalog overlay follows the established split-pane pattern from skill catalog.
SelectForAgentCreatecorrectly gates onpending_agent_idand providesnto skip.- Remove correctly restricted to
UserGlobaltemplates only.
| OverlayState::ModelPicker { .. } => KeyContext::ModelPicker, | ||
| OverlayState::ModelEffortPicker { .. } => KeyContext::ModelEffortPicker, | ||
| OverlayState::DebugPromptInput { .. } => KeyContext::DebugPromptInput, | ||
| OverlayState::DebugPromptInput { .. } | OverlayState::TemplateUrlInput { .. } => { |
There was a problem hiding this comment.
[warn] TemplateUrlInput is mapped to KeyContext::DebugPromptInput, coupling two semantically unrelated overlays to the same key context. If debug-prompt keybindings are later customized (e.g., adding autocomplete or history navigation), template URL input would inherit those changes unintentionally.
Suggestion: add a dedicated KeyContext::TemplateUrlInput variant so the two overlays can evolve independently.
Holon Run Report
|
Summary
/templatesTUI entry with catalog/selector supportagent createthrough template selection first, including remote GitHub template URL inputVerification