Fix KotlinDefaultArgumentsFilter for case when argument number 33 or higher has default value#1655
Merged
Merged
Conversation
Godin
marked this pull request as draft
July 27, 2024 09:05
Godin
force-pushed
the
kotlin_default_arguments
branch
from
January 17, 2025 08:09
2ca0150 to
0363397
Compare
Godin
marked this pull request as ready for review
January 17, 2025 08:54
leveretka
approved these changes
Jan 29, 2025
leveretka
left a comment
Collaborator
There was a problem hiding this comment.
Good catch! Looks good!
Let's maybe update the title mentioning the fact that it's when the default argument is at the 33+ position. Took me some time to understand what changed and I still had to ask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately modification in #1556 of KotlinDefaultArgumentsFilter for the case of more than 32 parameters was incomplete:
branches are shown for class "B" because condition
jacoco/org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/KotlinDefaultArgumentsFilter.java
Line 120 in 4f851ca
takes into account only the first mask argument.
Fixes #1750