Skip to content

Promise#288

Merged
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.1-11-02-p
Jul 9, 2020
Merged

Promise#288
joaquinelio merged 7 commits into
javascript-tutorial:masterfrom
cortizg:es.javascript.info.1-11-02-p

Conversation

@cortizg

@cortizg cortizg commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

se ha cerrado PR #188, este es su reemplazo. Razón: el branch anterior se eliminó

@javascript-translate-bot javascript-translate-bot requested a review from a team June 29, 2020 02:48
@javascript-translate-bot

javascript-translate-bot commented Jun 29, 2020

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #17, it's 188 ⁉️

@iliakan iliakan mentioned this pull request Jun 30, 2020
Open
@joaquinelio joaquinelio self-requested a review June 30, 2020 14:28
joaquinelio
joaquinelio requested changes Jun 30, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

salvo "prometedor" por objeto "promesa"
cambios menores y lo doy por bueno.
podrias buscar y poner apertura ¡
a los !
pero si no tenes ganas me olvido y miro para otro lado, no me importa

Comment thread 1-js/11-async/02-promise-basics/02-delay-promise/task.md Outdated
Comment thread 1-js/11-async/02-promise-basics/article.md
Comment thread 1-js/11-async/02-promise-basics/article.md Outdated
Comment thread 1-js/11-async/02-promise-basics/article.md
Comment thread 1-js/11-async/02-promise-basics/article.md
Comment thread 1-js/11-async/02-promise-basics/article.md Outdated
Comment thread 1-js/11-async/02-promise-basics/article.md Outdated
Comment thread 1-js/11-async/02-promise-basics/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Jun 30, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg

cortizg commented Jun 30, 2020

Copy link
Copy Markdown
Contributor Author

salvo "prometedor" por objeto "promesa"
cambios menores y lo doy por bueno.
podrias buscar y poner apertura ¡
a los !
pero si no tenes ganas me olvido y miro para otro lado, no me importa

Ok.... En casa lo reviso!

@cortizg @joaquinelio
Update 1-js/11-async/02-promise-basics/02-delay-promise/task.md
4d320d0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
cortizg
cortizg commented Jul 1, 2020
View reviewed changes

@cortizg cortizg left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acento

Comment thread 1-js/11-async/02-promise-basics/02-delay-promise/task.md Outdated
@cortizg cortizg requested a review from joaquinelio July 1, 2020 02:15
@cortizg

cortizg commented Jul 1, 2020

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 1, 2020 03:06
joaquinelio
joaquinelio approved these changes Jul 9, 2020
View reviewed changes

@joaquinelio joaquinelio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Una belleza, quién no va a entender las Promise ahora.
Me enamoré del sitio gracias a este capítulo.

@vplentinax vplentinax self-requested a review July 9, 2020 03:22
vplentinax
vplentinax approved these changes Jul 9, 2020
View reviewed changes

@vplentinax vplentinax left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@joaquinelio joaquinelio merged commit 1787914 into javascript-tutorial:master Jul 9, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 9, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

@vplentinax vplentinax vplentinax approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortizg @javascript-translate-bot @joaquinelio @vplentinax