Strings#230

Merged

tarasyyyk merged 9 commits into

javascript-tutorial:masterfrom

gingano:translation/strings

Dec 18, 2021

gingano commented Dec 9, 2021

Contributor

Strings

oleksii-kovalenko-gingano added 2 commits

December 9, 2021 14:42


          translation added

f65fcd2


          translation for tasks added

30e6b82

javascript-translate-bot added the review needed label

javascript-translate-bot commented Dec 9, 2021

Contributor

Error: the article has another translator @gingano) [translation requested](#1 (comment) in the Progress Issue #1.

CLAassistant commented Dec 9, 2021 •

edited

Loading

All committers have signed the CLA.

gingano commented Dec 9, 2021

Contributor Author

Error: the article has another translator @gingano) [translation requested](#1 (comment) in the Progress Issue #1.

@tarasyyyk it's ok ?

tarasyyyk requested changes

View reviewed changes

tarasyyyk left a comment

Collaborator

Дуже об’ємний переклад! Дякую за старання!
Я додав декілька правок

1-js/05-data-types/03-string/1-ucfirst/_js.view/test.js Outdated

1-js/05-data-types/03-string/1-ucfirst/_js.view/test.js Outdated

1-js/05-data-types/03-string/1-ucfirst/solution.md Outdated

1-js/05-data-types/03-string/1-ucfirst/solution.md Outdated

1-js/05-data-types/03-string/2-check-spam/_js.view/test.js Outdated

1-js/05-data-types/03-string/article.md Outdated

1-js/05-data-types/03-string/article.md Outdated

1-js/05-data-types/03-string/article.md Outdated

1-js/05-data-types/03-string/article.md Outdated

1-js/05-data-types/03-string/article.md Outdated

javascript-translate-bot removed the review needed label

javascript-translate-bot commented Dec 12, 2021

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

javascript-translate-bot added the changes requested label


          translation refactoring

0cda0b1

gingano commented Dec 15, 2021

Contributor Author

/done

javascript-translate-bot added review needed and removed changes requested labels

gingano requested a review from tarasyyyk

December 15, 2021 08:41

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/3-truncate/_js.view/test.js Outdated


          Update 1-js/05-data-types/03-string/3-truncate/_js.view/test.js

6dd2d84

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated


          Update 1-js/05-data-types/03-string/article.md

6a922c0

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated


          Update 1-js/05-data-types/03-string/article.md

a7e515c

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated


          Update 1-js/05-data-types/03-string/article.md

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk reviewed

View reviewed changes

1-js/05-data-types/03-string/article.md Outdated

tarasyyyk added 2 commits

December 17, 2021 20:54


          Apply suggestions from code review

a1ffd76


          Final corrections

d15d617

tarasyyyk approved these changes

View reviewed changes

tarasyyyk left a comment

Collaborator

Нарешті переклад цієї величезної статті завершено!
Велике Спасибі!

javascript-translate-bot added needs +1 and removed review needed labels

tarasyyyk commented Dec 17, 2021

Collaborator

@gingano, залишилось підписати CLA.

tarasyyyk added ready to merge and removed needs +1 labels

gingano requested a review from tarasyyyk

December 18, 2021 12:49

gingano commented Dec 18, 2021

Contributor Author

@tarasyyyk підписав, можеш мерджити

tarasyyyk commented Dec 18, 2021

Collaborator

@all-contributors add @gingano for translation.

allcontributors Bot mentioned this pull request

docs: add gingano as a contributor for translation #237

Merged

allcontributors Bot commented Dec 18, 2021

Contributor

I've put up a pull request to add @gingano! 🎉

tarasyyyk approved these changes

View reviewed changes

javascript-translate-bot added the needs +1 label

tarasyyyk merged commit a92f1be into javascript-tutorial:master

javascript-translate-bot commented Dec 18, 2021

Contributor

Error: the article has another translator @gingano) [translation requested](#1 (comment), not @gingano in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

tarasyyyk mentioned this pull request

Ukrainian Translation Progress #1

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 ready to merge