Fixed hypot bug on nan/inf pairings, began deprecation of non-real values#20754
Merged
Merged
Conversation
Micky774
commented
Apr 15, 2024
13 tasks
a9ec3fc to
2abcc4a
Compare
jakevdp
approved these changes
Apr 15, 2024
2abcc4a to
2899213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #20200
Begins deprecation of complex-valued inputs to
jax.numpy.hypot. Fixes bug whereinhypot(np.inf, np.nan)=np.naninstead of the expectednp.infresult as produced bynumpy.hypot.