Skip to content

🛡️ Add leads as codeowners of sensitive files#2291

Merged
webknjaz merged 2 commits into
jazzband:mainfrom
webknjaz:maintenance/codecowners
Nov 28, 2025
Merged

🛡️ Add leads as codeowners of sensitive files#2291
webknjaz merged 2 commits into
jazzband:mainfrom
webknjaz:maintenance/codecowners

Conversation

@webknjaz

@webknjaz webknjaz commented Nov 28, 2025

Copy link
Copy Markdown
Member

This currently protects .github/ and tox.ini as they may govern what automation gets into the repo and how releases happen.

Ref: #364

Contributor checklist
  • Included tests for the changes.
  • A change note is created in changelog.d/ (see changelog.d/README.md for instructions) or the PR text says "no changelog needed".
Maintainer checklist
  • If no changelog is needed, apply the bot:chronographer:skip label.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@webknjaz
🛡️ Add leads as codeowners of sensitive files
be76067 
This currently protects `.github/` and `tox.ini` as they may govern
what automation gets into the repo and how releases happen.

Ref: jazzband#364
@webknjaz webknjaz added this to the 7.5.3 milestone Nov 28, 2025
@webknjaz webknjaz requested a review from sirosen November 28, 2025 17:56
@webknjaz webknjaz added the maintenance Related to maintenance processes label Nov 28, 2025
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided A mark meaning that a new change log entry is present within the patch. label Nov 28, 2025
@webknjaz webknjaz mentioned this pull request Nov 28, 2025
Open
1 task
@webknjaz webknjaz enabled auto-merge November 28, 2025 17:59
sirosen
sirosen approved these changes Nov 28, 2025
View reviewed changes

@sirosen sirosen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@webknjaz

webknjaz commented Nov 28, 2025

Copy link
Copy Markdown
Member Author

We'll have to close+reopen the PR once the repo settings are fixed: jazzband/help#413 (comment).

@jezdez jezdez closed this Nov 28, 2025
auto-merge was automatically disabled November 28, 2025 18:10

Pull request was closed

@jezdez jezdez reopened this Nov 28, 2025
@webknjaz

webknjaz commented Nov 28, 2025

Copy link
Copy Markdown
Member Author

@sirosen looks like we got a flaky test?

@sirosen

sirosen commented Nov 28, 2025

Copy link
Copy Markdown
Member

Yeah, it looks like test_build_project_metadata_upgrading_raises_error is downloading setuptools on the fly, and we had a failure. It's hard to see what happened, the only detail I see in the logs is a little fragmentary:

stderr = b'WARNING: Skipping page https://pypi.org/simple/setuptools/ because the GET request got Content-Type: .The only suppo...e requirement setuptools>=40.8.0 (from versions: none)\nERROR: No matching distribution found for setuptools>=40.8.0\n'

I don't think we should block this PR, but I'd like to continue to look into this.

@webknjaz

webknjaz commented Nov 28, 2025

Copy link
Copy Markdown
Member Author

Oh, that's what I suspected but didn't see. This ties nicely into that discussion elsewhere about having own dumb backend stub instead of reaching into the internet.
I agree that it's not a blocker, just wanted to flag it.

@webknjaz webknjaz enabled auto-merge November 28, 2025 21:34
@webknjaz

webknjaz commented Nov 28, 2025

Copy link
Copy Markdown
Member Author

Looks like the same test failed in #2290. Probably around the same time.

@webknjaz webknjaz added this pull request to the merge queue Nov 28, 2025
Merged via the queue into jazzband:main with commit 2317649 Nov 28, 2025
84 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirosen sirosen sirosen approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided A mark meaning that a new change log entry is present within the patch. maintenance Related to maintenance processes

Projects

None yet

Milestone

7.5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@webknjaz @sirosen @jezdez