Skip to content

feat: explicitly mention that test is failing because done() is not being called #13847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 9 commits into from
Feb 2, 2023
+40 −3
Merged

feat: explicitly mention that test is failing because done() is not being called #13847

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
399f8cc
feat: explicitly mention that test is failing because done() is not b…
lpizzinidev Jan 31, 2023
6887488
added changelog entry
lpizzinidev Jan 31, 2023
eb85b63
fixed error message, extracted method call, and changed test expected…
lpizzinidev Jan 31, 2023
e0fd5f8
merged main branch
lpizzinidev Jan 31, 2023
b7c95d8
updated changelog entry
lpizzinidev Jan 31, 2023
b68595b
removed build message
lpizzinidev Jan 31, 2023
0ffb3f7
fix lint
lpizzinidev Jan 31, 2023
45a5d49
Update CHANGELOG.md
SimenB Feb 2, 2023
7bcbaf6
Merge branch 'main' into gh-13844
SimenB Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merged main branch
  • Loading branch information
@lpizzinidev
lpizzinidev committed Jan 31, 2023
commit e0fd5f8e6f41196f58077d0a8c0fa8a7622dbddc
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

- `[expect, jest-circus, @jest/types]` Implement `numPassingAsserts` of testResults to track the number of passing asserts in a test ([#13795](https://github.com/facebook/jest/pull/13795))
- `[jest-core]` Add newlines to JSON output ([#13817](https://github.com/facebook/jest/pull/13817))
- `[jest-circus]` Added explicit mention of test failing because `done()` is not being called in error message ([#13847](https://github.com/facebook/jest/pull/13847))
- `[@jest/reporters]` Automatic log folding in GitHub Actions Reporter ([#13626](https://github.com/facebook/jest/pull/13626))

### Fixes

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.