[Enhance] forbid-component-props accepts allowedForRegex and disallowedForRegex#3687
Closed
bschlenk wants to merge 5 commits into
Closed
[Enhance] forbid-component-props accepts allowedForRegex and disallowedForRegex#3687bschlenk wants to merge 5 commits into
bschlenk wants to merge 5 commits into
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3687 +/- ##
==========================================
- Coverage 97.74% 97.73% -0.01%
==========================================
Files 132 132
Lines 9409 9420 +11
Branches 3449 3454 +5
==========================================
+ Hits 9197 9207 +10
- Misses 212 213 +1 ☔ View full report in Codecov by Sentry. |
Member
|
PR was a bit premature; regexes in eslint configs are hugely insecure and a CVE farm, and should never exist. |
2 tasks
380e32c to
51d342b
Compare
Contributor
|
This is solved in #3774, can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3686