Skip to content

Fixes to work with Python 3.12+#254

Open
bje- wants to merge 3 commits into
klen:developfrom
bje-:develop
Open

Fixes to work with Python 3.12+#254
bje- wants to merge 3 commits into
klen:developfrom
bje-:develop

Conversation

@bje-

@bje- bje- commented Jun 21, 2024

Copy link
Copy Markdown

This patch removes the dependence on pkg_resources which is not available by default in Python 3.12 and beyond. It switches from pkg_resources.iter_entry_points to import_metadata.entry_points. import_metadata is available in all supported versions of Python.

The other change removes the use of parse_requirements and just hardcodes the package dependencies in setup.py, which is arguably good practice anyway since not all developer-installed packages are required by the installation.

Finally, setuptools is added to requirements.txt since it is also no longer installed by default with Python 3.12.

@bje-
- Switch from pkg_resources to importlib_metadata.
e34d6d4 
- Eliminate the use of pkg_resources which is no longer installed with
  Python 3.12 and greater.

- Add setuptools to requirements.txt which is no longer included in
  Python distributions (>= 3.12).
@bje- bje- mentioned this pull request Jun 21, 2024
Open
This was referenced Jul 7, 2024
Closed
Closed
@smithcommajoseph smithcommajoseph mentioned this pull request Aug 28, 2024
Merged
@rmax rmax mentioned this pull request Oct 26, 2024
Open
@kingthorin kingthorin mentioned this pull request Dec 22, 2024
Merged
@bje-

bje- commented Apr 9, 2025

Copy link
Copy Markdown
Author

Ping?

@bje-

bje- commented Jun 8, 2025

Copy link
Copy Markdown
Author

Can this PR be merged, please?

@Famlam

Famlam commented Jun 8, 2025

Copy link
Copy Markdown

Maybe ping @klen in case it went unnoticed

It seems that even installing setuptools manually will stop working soon

UserWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html. The pkg_resources package is slated for removal as early as 2025-11-30. Refrain from using this package or pin to Setuptools<81.

@mshonichev

mshonichev commented Aug 11, 2025

Copy link
Copy Markdown

ping @klen :)

Can this PR be merged, please, it's very annoying to suppress warnings in CI and it freaks me out that pylama would stop working after CI pipelines upgrade to python 3.12

@DanielNoord DanielNoord mentioned this pull request Oct 6, 2025
Merged
b-layer
b-layer reviewed Nov 24, 2025
View reviewed changes

@b-layer b-layer left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about import_metadata (with underscore)? Not found for me when I merged this locally. Docs say import.metadata (with period) and that works. (Python 3.12.12)

@cjwatson

cjwatson commented Jan 29, 2026

Copy link
Copy Markdown

Are you sure about import_metadata (with underscore)? Not found for me when I merged this locally. Docs say import.metadata (with period) and that works. (Python 3.12.12)

importlib_metadata does exist as a backport, but at this point there's no reason to use it any more; all supported Python versions have importlib.metadata in the stdlib. It might be worth explicitly declaring a new enough python_requires.

@bje-

bje- commented Jan 29, 2026

Copy link
Copy Markdown
Author

importlib_metadata does exist as a backport, but at this point there's no reason to use it any more; all supported Python versions have importlib.metadata in the stdlib. It might be worth explicitly declaring a new enough python_requires.

I've updated the PR.

@Marc-marc-marc Marc-marc-marc mentioned this pull request Feb 12, 2026
Closed
@phettberg phettberg mentioned this pull request Feb 12, 2026
Merged
@cnagarjuna

cnagarjuna commented Feb 25, 2026

Copy link
Copy Markdown

Can this PR be merged, please?

@Marc-marc-marc

Marc-marc-marc commented Feb 25, 2026

Copy link
Copy Markdown

For your information, there is another fork that seems more advanced, with fixes for this issue as well.
https://github.com/ccxcz/pylama.git
It might be useful for the two fixes to check each other and converge towards a common fix.
This would be useful if this upstream ever comes back to life.
ping @ccxcz @tunecrew involved in these improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@b-layer b-layer b-layer left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bje- @Famlam @mshonichev @cjwatson @cnagarjuna @Marc-marc-marc @b-layer