ci(l1): update to new ethereum package version.#3860
Merged
Conversation
…lt ethrex version.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI infrastructure to use the official ethereum-package repository instead of a fork, streamlining the testing setup and aligning with upstream changes.
- Updated ethereum-package source from fork to official repository with new revision
- Added explicit ethrex:latest image specification across network configuration files
- Removed deprecated electra_fork_epoch parameters that are no longer needed
- Enhanced Makefile checkout process with better revision checking logic
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| fixtures/network/*.yaml | Added explicit ethrex:latest image and removed deprecated electra_fork_epoch |
| .github/config/assertoor/*.yaml | Updated network parameters with ethrex image specification and cleanup |
| .github/workflows/pr-main_l1.yaml | Updated to use official ethereum-package with new Kurtosis version and caching |
| Makefile | Improved checkout-ethereum-package task with better revision management |
| cmd/ethrex/initializers.rs | Downgraded error to warning for peers file read failures |
Comments suppressed due to low confidence (1)
.github/workflows/pr-main_l1.yaml:159
- Kurtosis version 2.1.0 may not exist. My knowledge cutoff is January 2025, and it's currently July 2025, so this version might be valid. Please verify this version exists in the Kurtosis releases.
kurtosis_version: "2.1.0"
mpaulucci
commented
Jul 31, 2025
| needs: [docker_build] | ||
| if: ${{ github.event_name != 'merge_group' }} | ||
| strategy: | ||
| fail-fast: true |
Collaborator
Author
There was a problem hiding this comment.
this is the default, just making it explicit. Sometimes I want to change it to false when testing stuff
mpaulucci
commented
Jul 31, 2025
| match read_node_config_file(config_file) { | ||
| Ok(ref mut config) => bootnodes.append(&mut config.known_peers), | ||
| Err(e) => error!("Could not read from peers file: {e}"), | ||
| Err(e) => warn!("Could not read from peers file: {e}"), |
Collaborator
Author
There was a problem hiding this comment.
Theres an issue to fix this properly: #3908
mpaulucci
commented
Jul 31, 2025
| validator_count: 32 | ||
| count: 2 | ||
| - el_type: ethrex | ||
| el_image: ethrex:latest |
Collaborator
Author
There was a problem hiding this comment.
This is now needed because the default is the deployed version: https://github.com/ethpandaops/ethereum-package/blob/82e5a7178138d892c0c31c3839c89d53ffd42d9a/src/package_io/input_parser.star#L17
ManuelBilbao
approved these changes
Jul 31, 2025
rodrigo-o
approved these changes
Aug 1, 2025
rodrigo-o
left a comment
Contributor
There was a problem hiding this comment.
Looking good, just left one comment!
Comment on lines
-13
to
-16
| network_params: | ||
| # The address of the staking contract address on the Eth1 chain | ||
| deposit_contract_address: "0x4242424242424242424242424242424242424242" | ||
|
|
Contributor
There was a problem hiding this comment.
This is not needed anymore? maybe we can remove it from the other ones?
Collaborator
Author
There was a problem hiding this comment.
yes its needed, I moved it further down in the same file
Oppen
pushed a commit
that referenced
this pull request
Aug 1, 2025
**Motivation** Start using the official `ethrereum-package` repo instead of a fork **Description** See ethpandaops/ethereum-package#1131 - Updated version of ethereum-package to use the lastest one instead of a fork - Improved `checkout-ethereum-package` make task - Made sure we're using the local build of ethrex everywhere - Downgraded an error to warning Closes #595
LeanSerra
pushed a commit
that referenced
this pull request
Aug 12, 2025
**Motivation** Start using the official `ethrereum-package` repo instead of a fork **Description** See ethpandaops/ethereum-package#1131 - Updated version of ethereum-package to use the lastest one instead of a fork - Improved `checkout-ethereum-package` make task - Made sure we're using the local build of ethrex everywhere - Downgraded an error to warning Closes #595
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Start using the official `ethrereum-package` repo instead of a fork **Description** See ethpandaops/ethereum-package#1131 - Updated version of ethereum-package to use the lastest one instead of a fork - Improved `checkout-ethereum-package` make task - Made sure we're using the local build of ethrex everywhere - Downgraded an error to warning Closes lambdaclass#595
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Start using the official
ethrereum-packagerepo instead of a forkDescription
See ethpandaops/ethereum-package#1131
checkout-ethereum-packagemake taskCloses #595