[DirectX] Replace getNextNonDebugInstruction with getNextNode#148890
Merged
Conversation
tex3d
approved these changes
Jul 15, 2025
bogner
approved these changes
Jul 15, 2025
Member
|
@llvm/pr-subscribers-backend-directx Author: Deric C. (Icohedron) ChangesFixes the DirectX backend build failure due to #144383 Full diff: https://github.com/llvm/llvm-project/pull/148890.diff 1 Files Affected:
diff --git a/llvm/lib/Target/DirectX/DXILDataScalarization.cpp b/llvm/lib/Target/DirectX/DXILDataScalarization.cpp
index cfe270d432144..d9d9b36d0b739 100644
--- a/llvm/lib/Target/DirectX/DXILDataScalarization.cpp
+++ b/llvm/lib/Target/DirectX/DXILDataScalarization.cpp
@@ -202,7 +202,7 @@ DataScalarizerVisitor::createArrayFromVector(IRBuilder<> &Builder, Value *Vec,
// original vector's defining instruction if available, else immediately after
// the alloca
if (auto *Instr = dyn_cast<Instruction>(Vec))
- Builder.SetInsertPoint(Instr->getNextNonDebugInstruction());
+ Builder.SetInsertPoint(Instr->getNextNode());
SmallVector<Value *, 4> GEPs(ArrNumElems);
for (unsigned I = 0; I < ArrNumElems; ++I) {
Value *EE = Builder.CreateExtractElement(Vec, I, Name + ".extract");
|
AnthonyLatsis
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jun 24, 2026
🍒 [DirectX] Replace `getNextNonDebugInstruction` with `getNextNode` (llvm#148890)
joeybrinker
pushed a commit
to joeybrinker/llvm-project
that referenced
this pull request
Jun 25, 2026
…vm#148890) Fixes the DirectX backend build failure due to llvm#144383 (cherry picked from commit a4dab50)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the DirectX backend build failure due to #144383