Compare category IDs as ints in _get_category_by_id#38
Merged
Conversation
_get_category_by_id matched with 'c.get("ID") == term_id'. The WP.com API
sometimes returns term IDs as strings (the tree builder already coerces for
this reason), so a string '49' in the cache would not equal an int 49 and
the lookup returned None — a spurious 404 that aborts an apply or restore
mid-run. Coerce both sides to int before comparing. Add a regression test
with a string-typed ID from the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_category_by_idmatched withc.get('ID') == term_id. The WP.com API sometimes returns term IDs as strings (the tree builder already coerces for this reason), so a string'49'in the cache wouldn't equal an int49and the lookup returnedNone, a spurious 404 that aborts an apply or restore mid-run.This coerces both sides to
intbefore comparing. I added a regression test with a string-typed ID from the API.While testing against a live Jetpack site, passing a string term ID to
set_post_categoriesresolved correctly.Testing
python3 -m unittest discover tests— greenruff check lib/ tests/— clean