bug: Fix external go to definition#10099
Merged
Light2Dark merged 2 commits intoJul 8, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CodeMirror cell go-to-definition keybinding so it can “fall through” to lower-priority keymaps (e.g., LSP-provided go-to-definition) when marimo’s reactive-variable resolver can’t handle the symbol, addressing external code navigation (closes #7135).
Changes:
- Adjust cell go-to-definition keybinding to return the resolver result instead of always consuming the shortcut.
- Add a regression test to ensure a lower-priority keymap can handle go-to-definition when the marimo handler returns
false.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/core/codemirror/cells/extensions.ts | Lets the go-to-definition keybinding fall through by returning the resolver boolean. |
| frontend/src/core/codemirror/tests/setup.test.ts | Adds a test asserting fall-through to a lower-priority keymap handler. |
1 task
Co-authored-by: OpenAI Codex <codex@openai.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Let the local notebook go-to-definition keybinding return false when it cannot resolve a symbol, so lower-precedence LSP keybindings can handle external definitions. Co-authored-by: OpenAI Codex <codex@openai.com>
yairchu
force-pushed
the
fix-external-go-to-definition
branch
from
July 8, 2026 09:18
5282e72 to
0fc6a79
Compare
Contributor
Author
|
CI is failing on missing PR label, but I can't seem to be able to edit the labels for it |
Light2Dark
approved these changes
Jul 8, 2026
6 tasks
Light2Dark
added a commit
that referenced
this pull request
Jul 9, 2026
…ck (#10102) **This pull request was authored by a coding agent.** ## 📝 Summary Follow-up to #10099 / #7135. F12 go-to-definition already falls through to the language server when marimo cannot resolve a symbol. This PR extends that same fallback to the other entry points: - Context menu "Go to Definition" - Cmd/Ctrl+click navigation Adds a shared `goToDefinitionWithLspFallback` helper that tries marimo's notebook resolver first, then triggers the LSP keybinding via `runScopeHandlers`. ## 📋 Pre-Review Checklist - [x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] Any AI generated code has been reviewed line-by-line by the human PR author, who stands by it. - [ ] Video or media evidence is provided for any visual changes (optional). ## ✅ Merge Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [x] Documentation has been updated where applicable, including docstrings for API changes. - [x] Tests have been added for the changes made. Made with [Cursor](https://cursor.com) --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes contributions from a coding agent.
📝 Summary
Closes #7135
📋 Pre-Review Checklist
✅ Merge Checklist