fix: update snapshots and types for altair v6.1.0 / vega-lite v6.4.1#9415
Merged
Conversation
CI was failing on main after the altair upgrade landed: - snapshots referenced vega-lite v6.1.0 schema and old view-hash names - alt.layer now returns LayerChart | FacetChart, breaking add_common_config - vlc.get_*_locale signatures became Literal-typed
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
No issues found across 23 files
Architecture diagram
sequenceDiagram
participant User as "User/Notebook"
participant Charts as "marimo._data.charts"
participant Altair as "Altair v6.1.0+"
participant Format as "marimo._output.formatters"
participant VLC as "vl-convert (External)"
participant Snap as "Test Snapshots"
Note over User,Altair: Chart Creation & Configuration
User->>Altair: Define Chart (Layered or Faceted)
User->>Charts: add_common_config(chart)
rect rgb(240, 240, 240)
Note right of Charts: CHANGED: Supports alt.FacetChart<br/>returned by v6.1.0 layers
Charts->>Altair: chart.properties(width='container')
Charts->>Altair: chart.configure_view(stroke=None)
end
Altair-->>User: Configured Chart Object
Note over User,VLC: Serialization & Locale Handling
User->>Format: render(chart)
Format->>VLC: CHANGED: get_format_locale(locale)
Note right of VLC: Literal-typed signatures<br/>enforced via type ignore
VLC-->>Format: Locale Dict
Format->>Format: Generate Vega-Lite JSON
Note right of Format: NEW: Schema v6.4.1<br/>NEW: Updated view-hash naming<br/>NEW: join() tooltips for arrays
Note over Format,Snap: Regression Testing
Format->>Snap: Compare generated JSON
alt Success
Snap-->>Format: Match
else CHANGED: Schema/Hash Mismatch
Snap-->>Format: Fail (requires update)
end
vega-lite 6.4.2 (2026-01-14) ships vega-lite#9707, which fixes the "undefined" numeric tooltip with selection_point(nearest=True). Drop the CI guard and renovate exclusion that pinned us to 6.3.1 for that reason.
Contributor
Author
|
Verified the numeric tooltip bug is no longer there. Details
|
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.4-dev19 |
Bundle ReportChanges will decrease total bundle size by 24.13kB (-0.1%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: marimo-esmAssets Changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing on main after the altair upgrade landed: