Skip to content

Update workflow with actions/checkout@v3 to actions/checkout@v4#21872

Merged
michalkleiner merged 2 commits into
matomo-org:5.x-devfrom
digitalist-se:5.x-dev
Feb 6, 2024
Merged

Update workflow with actions/checkout@v3 to actions/checkout@v4#21872
michalkleiner merged 2 commits into
matomo-org:5.x-devfrom
digitalist-se:5.x-dev

Conversation

@mikkeschiren

@mikkeschiren mikkeschiren commented Feb 3, 2024 •
edited by michalkleiner
Loading

Copy link
Copy Markdown
Contributor

Description:

actions/checkout@v3 is deprecated, and shouldn't be used any more.
Also some minor fixes on removal of whitespaces.

A warning can be seen e.g. in the PHPCS action:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Review

@michalkleiner

michalkleiner commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

Hi @mikkeschiren and thank you for your contribution and opening the PR.
Would you happen to have a link to some information about the v3 action being deprecated?

@michalkleiner michalkleiner requested a review from a team February 4, 2024 09:33
@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review Technical debt Issues the will help to reduce technical debt labels Feb 4, 2024
@mikkeschiren

mikkeschiren commented Feb 4, 2024

Copy link
Copy Markdown
Contributor Author

Hi @mikkeschiren and thank you for your contribution and opening the PR. Would you happen to have a link to some information about the v3 action being deprecated?

Hi, sorry for not including that, you can see it in the output here as an example: https://github.com/matomo-org/matomo/actions/runs/7758937941

More information here: actions/checkout#1436

@michalkleiner

michalkleiner commented Feb 4, 2024

Copy link
Copy Markdown
Contributor

Since all the checkout actions seem to work correctly with v4 and the failures are only the flaky tests we already know about, I'm happy with this.

I'm of two minds as to which branch it should target. For me it's a maintenance PR and could/should target 5.0.x-dev and then merged up to 5.x-dev, do you agree @sgiehl?

@sgiehl

sgiehl commented Feb 5, 2024

Copy link
Copy Markdown
Member

No big preference where to merge that to. As v3 will still work for a long time, there is no real need to have it in 5.0.x-dev, but wouldn't hurt either. As changing the base branch and rebasing the origin would be additional work I would also be fine with simply merging it as is.

@michalkleiner michalkleiner merged commit e8be0cf into matomo-org:5.x-dev Feb 6, 2024
@sgiehl sgiehl added this to the 5.1.0 milestone Feb 6, 2024
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@michalkleiner michalkleiner michalkleiner approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Technical debt Issues the will help to reduce technical debt

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mikkeschiren @michalkleiner @sgiehl