Chrome 105 / Deno 1.7 / Node 18 support fetch() with ReadableStream body#25636
Merged
Conversation
Fixes #12188. Chrome bug: https://issues.chromium.org/issues/40505032 Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi\?id\=1387483 Safari bug: https://bugs.webkit.org/show_bug.cgi\?id\=176066 Chrome impl: https://chromiumdash.appspot.com/commit/9bbd1d6504a1d63d1b409e696c522497b111a572 Safari impl: WebKit/WebKit@67cb061
caugner
commented
Jan 13, 2025
fetch() with ReadableStream bodyfetch() with ReadableStream body
caugner
commented
Jan 13, 2025
7615275 to
5bedd8e
Compare
fetch() with ReadableStream bodyfetch() with ReadableStream body
Contributor
Author
|
@skyclouds2001 Since you have some experience researching Node.js support, could you help me out here? It looks like Does this make sense to you? PS: In Firefox, the test case logs: |
Contributor
Author
|
Oh, never mind, I just saw in the comments that the previous implementation seems to have already supported streams. |
caugner
commented
Jan 13, 2025
Merged
Contributor
|
yes, node support is before 18.13.0, https://github.com/nodejs/node/blame/3e57891ee2fde0971e18fc383c25acf8f90def05/deps/undici/src/lib/fetch/body.js#L200-L209:~:text=ReadableStream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add subfeature for the fetch spec change allowing
ReadableStreamasfetch()body in 2017.Test results and supporting details
Test case:
Related issues
Fixes #12188.