Fix crash when private id in array assignment#53665
Merged
Merged
Conversation
jakebailey
requested review from
DanielRosenwasser,
RyanCavanaugh and
andrewbranch
April 5, 2023 04:29
andrewbranch
approved these changes
Apr 5, 2023
DanielRosenwasser
approved these changes
Apr 5, 2023
Member
Author
|
@typescript-bot cherry-pick this to release-5.0 |
Contributor
|
Heya @jakebailey, I've started to run the task to cherry-pick this into |
Contributor
|
Hey @jakebailey, I've opened #53677 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Apr 5, 2023
Component commits: 8adc6ca Fix crash when private id in array assignment
DanielRosenwasser
pushed a commit
that referenced
this pull request
Apr 5, 2023
…e-5.0 (#53677) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
drivron
pushed a commit
to scenari/typescript
that referenced
this pull request
Sep 14, 2023
…to release-5.0 (microsoft#53677) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #53114
For #53637
This is for the second repro.
I added this assert in the SFT PR, but we can just make it a conditional instead, as this code is already invalid syntactically, but not technically an invalid AST type-wise.