Skip to content

[codex] Guard desktop release signing#25

Merged
DragonnZhang merged 2 commits into
mainfrom
dragon/remove-settings-about-version
Jun 10, 2026
Merged

[codex] Guard desktop release signing#25
DragonnZhang merged 2 commits into
mainfrom
dragon/remove-settings-about-version

Conversation

@DragonnZhang

Copy link
Copy Markdown
Collaborator

Summary

  • reject macOS auto-update checks when the installed app only has an ad-hoc or otherwise unsuitable code signature
  • derive the updater cache directory from app-update.yml and ensure generated electron-builder metadata uses the OpenWork app name
  • split macOS and Windows signing secrets in the desktop release workflow, while allowing explicitly opted-in unsigned prerelease test builds

Testing

  • bun test apps/electron/src/main/tests/auto-update-signature.test.ts
  • npx eslint src/main/auto-update.ts src/main/auto-update-signature.ts src/main/tests/auto-update-signature.test.ts
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/desktop-release.yml"); puts "workflow yaml ok"'\n- git diff --check\n- CRAFT_BRAND=openwork bun run electron:builder-config\n\n## Notes\nUnsigned prerelease builds are only for manual tester installs. They do not validate the macOS auto-update path.

@DragonnZhang DragonnZhang marked this pull request as ready for review June 10, 2026 07:58
@DragonnZhang DragonnZhang merged commit 6a63d40 into main Jun 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant