Allow unsigned Windows desktop release#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Relaxed the Windows branch of
desktop-release.ymlso desktop releases no longer fail whenWIN_CSC_LINKandWIN_CSC_KEY_PASSWORDare absent.Why
release up desktopwas still treating Windows signing as mandatory for published releases, which does not match the intended OpenWork release flow.Root cause
The workflow still hard-failed in the Windows signing setup step when no Windows certificate secrets were configured. That logic was left in place even though the Windows release channel is expected to support unsigned artifacts.
Impact
Windows desktop release jobs can now continue without signing credentials. Dry runs keep the informational unsigned message, and published releases now emit a warning instead of failing.
Validation
git diff --checknpx prettier --check .github/workflows/desktop-release.yml