[codex] Preserve Windows shell for desktop release builds#7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes the follow-up Windows failure in the Desktop Release workflow by removing the build job's global bash default shell. The version bump/check steps now receive the normalized release version through GitHub Actions expression interpolation, while the signing-secret setup step keeps its explicit bash shell because it uses bash syntax.
Why it's needed
Run https://github.com/modelstudioai/openwork/actions/runs/27130552884 showed that the previous fix worked for macOS, Linux, and the Windows version steps, but Windows packaging then ran under Git Bash. During
electron:vendor:qwen,tar.exe -xzf C:\...\qwen-code-0.15.11.tgzwas interpreted as a remotehost:pathvalue and failed withCannot connect to C: resolve failed. Windows packaging should run in the runner default shell instead of inheriting bash from unrelated workflow steps.Reviewer Test Plan
How to verify
Re-run the Desktop Release workflow for version
0.0.2. The Windows job should keep the version bump/check success from the previous run, then proceed pastelectron:vendor:qwenwithout theCannot connect to Ctar error. macOS and Linux should continue using their default shell behavior and remain green.Evidence (Before & After)
Before: GitHub Actions run https://github.com/modelstudioai/openwork/actions/runs/27130552884 failed in Build Windows at
tar.exe -xzf C:\Users\RUNNER~1\AppData\Local\Temp\...\qwen-code-0.15.11.tgzwithCannot connect to C: resolve failed.After: Local workflow validation passed with
actionlint, YAML parsing,git diff --check, andbun run bump-desktop-version --dry-run 0.0.2.Tested on
Environment (optional)
Local macOS shell in
/Users/dragon/Documents/openwork; hosted Windows failure inspected withgh.Risk & Scope
shell: bashexplicitly.Linked Issues
References https://github.com/modelstudioai/openwork/actions/runs/27130552884
中文说明
What this PR does
这个 PR 修复 Desktop Release workflow 的后续 Windows 失败：去掉 build job 级别的全局 bash 默认 shell。版本 bump/check 步骤现在通过 GitHub Actions 表达式直接拿到标准化后的版本号；签名 secret 配置步骤因为使用 bash 语法，继续单独指定
shell: bash。Why it's needed
Run https://github.com/modelstudioai/openwork/actions/runs/27130552884 说明上一个修复已经让 macOS、Linux 和 Windows 版本步骤通过，但 Windows packaging 继承了 Git Bash。执行
electron:vendor:qwen时，tar.exe -xzf C:\...\qwen-code-0.15.11.tgz被当成远程host:path解析，最终报Cannot connect to C: resolve failed。Windows 打包应该回到 runner 默认 shell，而不是继承和它无关的 bash 设置。Reviewer Test Plan
How to verify
重新运行 Desktop Release workflow，版本填
0.0.2。Windows job 应该保留上一次 run 里版本 bump/check 通过的结果，并继续跑过electron:vendor:qwen，不再出现Cannot connect to C的 tar 错误。macOS 和 Linux 应该继续使用各自默认 shell 并保持绿色。Evidence (Before & After)
Before: GitHub Actions run https://github.com/modelstudioai/openwork/actions/runs/27130552884 的 Build Windows 在
tar.exe -xzf C:\Users\RUNNER~1\AppData\Local\Temp\...\qwen-code-0.15.11.tgz处失败，错误是Cannot connect to C: resolve failed。After: 本地已通过
actionlint、YAML 解析、git diff --check，以及bun run bump-desktop-version --dry-run 0.0.2。Tested on
Environment (optional)
本地 macOS shell，目录
/Users/dragon/Documents/openwork；托管 Windows 失败日志通过gh查看。Risk & Scope
shell: bash。Linked Issues
References https://github.com/modelstudioai/openwork/actions/runs/27130552884