Update footer to match Firefox.com#14225
Conversation
5e68ee4 to
96c9a70
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14225 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 266 266
Lines 10646 10647 +1
Branches 3285 3285
=======================================
+ Hits 10446 10447 +1
Misses 187 187
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| max-width: $max-content-width; | ||
| width: 100%; | ||
| gap: 0 2em; | ||
| } |
There was a problem hiding this comment.
Just a thought: I am wondering if we shouldn't display: flex the sections instead of attempting to keep the grid.
There was a problem hiding this comment.
My first instinct was to use flex since I was more familiar with it, but given the remaining elements were left justified I was concerned about keeping size in sync in both rows on wrap when stretching elements to fill the space.
There was a problem hiding this comment.
Actually, looking again, there's a scss mixin workaround that looks more verbose. I'll likely try that out.
There was a problem hiding this comment.
(Results in some misaligned between states.)
cdee522 to
c72d421
Compare
c72d421 to
26450c8
Compare
Relates to mozilla/addons#15925 .
Updates the footer on AMO to better match Firefox.com.
Added additional breakpoint state, since columns became narrower faster but would leave too much empty space.