Skip to content

TSL: Add OnFrameUpdate and OnBeforeFrameUpdate#33356

Merged
sunag merged 1 commit into
mrdoob:devfrom
shotamatsuda:feat/frame-event-node
Apr 10, 2026
Merged

TSL: Add OnFrameUpdate and OnBeforeFrameUpdate#33356
sunag merged 1 commit into
mrdoob:devfrom
shotamatsuda:feat/frame-event-node

Conversation

@shotamatsuda

@shotamatsuda shotamatsuda commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds OnFrameUpdate and OnBeforeFrameUpdate TSL functions for EventNode. They are useful for defining updates without broadening the scope used in event callbacks.

Although it appears to work as intended, I might be missing something about why they were not included in the first place.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 360.57
85.58
360.57
85.58
+0 B
+0 B
WebGPU 635.48
176.41
635.7
176.46
+213 B
+48 B
WebGPU Nodes 633.6
176.11
633.81
176.16
+213 B
+47 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 492.95
120.2
492.95
120.2
+0 B
+0 B
WebGPU 707.66
191.31
707.79
191.34
+124 B
+33 B
WebGPU Nodes 656.88
178.57
657.01
178.64
+124 B
+75 B

@shotamatsuda shotamatsuda marked this pull request as ready for review April 9, 2026 10:02
@sunag sunag merged commit 8daef3c into mrdoob:dev Apr 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants