484 update setup instructions#485
Merged
Merged
Conversation
jmbrunskill
approved these changes
Dec 22, 2023
jmbrunskill
left a comment
Contributor
There was a problem hiding this comment.
I like everything in one place like this.
Nice touch with the dgraph-tests feature, I was actually thinking about doing something like this today.
| tokio = { version = "1", features = ["full"] } | ||
| gql_client = "1.0.7" | ||
|
|
||
| [features] |
Contributor
There was a problem hiding this comment.
Suggested change
| [features] | |
| [features] | |
| default = ["dgraph-tests"] |
Contributor
There was a problem hiding this comment.
This is basically because I feel like it would be good to run our dgraph tests regularly as devs, so would rather disable them in CI rather than have to enable the every time in our IDE.
Although we can set features on for a VS code workspace so I'm happy if you leave it as is.
Contributor
Author
There was a problem hiding this comment.
Nah nice I like this!
Co-authored-by: James Brunskill <james@jambe.co.nz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #484
Description
Update the readme setup instructions, as well as adding some extra yarn scripts, after we've brought in the Rust backend.
This is a slightly different approach than usual, where we keep the frontend and backend dirs and the running of their scripts separate... it may (?) be worth going back to the usual pattern, but this would require another folder rearrange.
Also puts the dgraph tests behind a feature flag so that the backend tests can run in CI!