Skip to content

https: make opts optional & immutable when create #13599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XadillaX wants to merge 8 commits into from
Closed

https: make opts optional & immutable when create #13599

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
26d4efb
https: make opts optional & immutable when create
XadillaX Jun 10, 2017
2c7ff7b
use Object.assign to instead of util._extend
XadillaX Jun 10, 2017
b3a1ac6
use the default message in common.mustNotCall
XadillaX Jun 10, 2017
9414765
update after reviewing
XadillaX Jun 10, 2017
c798af8
add test case for no argument
XadillaX Jun 10, 2017
5de8cf2
use blocks to instead of server1, server2, ...
XadillaX Jun 10, 2017
dc2291c
add test skip
XadillaX Jun 11, 2017
2232fad
delete default param to prevent some breaking changes
XadillaX Jun 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use the default message in common.mustNotCall
  • Loading branch information
@XadillaX
XadillaX committed Jun 10, 2017
commit b3a1ac6e7f357063c14126a1e4bf1dac76130303
2 changes: 1 addition & 1 deletion test/parallel/test-https-immutable-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const server1 = https.createServer(opts);
assert.deepStrictEqual(opts, { foo: 'bar' });
assert.strictEqual(server1.NPNProtocols.compare(dftProtocol.NPNProtocols), 0);

@mscdex mscdex Jun 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should suffice to just compare the NPNProtocols references. That way we know for sure that our options weren't overridden:

assert.strictEqual(server1.NPNProtocols, dftProtocol.NPNProtocols);

@XadillaX XadillaX Jun 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscdex I think we can't, because NPNProtocols hasn't been cached yet. 2 calls to tls.convertNPNProtocols won't return the same reference.

@mscdex mscdex Jun 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok I see it now. Perhaps we should at least choose a different set of protocols then, so as to differentiate from the default NPN protocols (perhaps just use one protocol?).


const mustNotCall = common.mustNotCall('dummy callback');
const mustNotCall = common.mustNotCall();
const server2 = https.createServer(mustNotCall);

@mscdex mscdex Jun 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment below doesn't match the behavior of this line. If we're testing no arguments, it should just be https.createServer().

Otherwise we could add a separate test below for no arguments.


assert.strictEqual(server2.NPNProtocols.compare(dftProtocol.NPNProtocols), 0);
Expand Down