Skip to content

BREAKING: deprecate loading files with unknown or missing extensions #15365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 4 commits into from
Closed

BREAKING: deprecate loading files with unknown or missing extensions #15365

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f2b068
module: deprecate loading files with unknown or missing extensions
bmeck Sep 12, 2017
54f3112
should only create 1 deprecate function
bmeck Sep 12, 2017
ed60ce4
fix long line
bmeck Sep 12, 2017
2f35f90
doc touchup
bmeck Sep 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
should only create 1 deprecate function
  • Loading branch information
@bmeck
bmeck committed Sep 12, 2017
commit 54f31125076bdb64853a145836539ac0e2d8341c
8 changes: 4 additions & 4 deletions lib/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,9 @@ Module._resolveFilename = function(request, parent, isMain) {
return filename;
};


const DEPRECATED_EXTENSION_FILLING = internalUtil.deprecate(() => {
return '.js';
}, 'Loading files without an extension or unknown extension is deprecated', 'DEP0077');

@thefourtheye thefourtheye Sep 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line has more than 80 characters.

// Given a file name, pass it to the proper extension handler.
Module.prototype.load = function(filename) {
debug('load %j for module %j', filename, this.id);
Expand All @@ -519,9 +521,7 @@ Module.prototype.load = function(filename) {

var extension = path.extname(filename);
if (!extension || !Module._extensions[extension]) {
internalUtil.deprecate(() => {
extension = '.js';
}, 'Loading files without an extension or unknown extension is deprecated', 'DEP0077')();
extension = DEPRECATED_EXTENSION_FILLING();
};
Module._extensions[extension](this, filename);
this.loaded = true;
Expand Down