Skip to content

src: set thread local env in CreateEnvironment #18573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 5 commits into from
Closed

src: set thread local env in CreateEnvironment #18573

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2ae326
src: set thread local env in CreateEnvironment
danbev Feb 5, 2018
e047cb0
squash: remove this for Env contstructor call
danbev Feb 6, 2018
6dee9c8
squash: move code into Environment to avoid dupl
danbev Feb 13, 2018
3bceaee
squash: use uv_once_t to create the thread local
danbev Feb 15, 2018
b5761a7
squash: remove white spaces added
danbev Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: remove this for Env contstructor call
  • Loading branch information
@danbev
danbev committed Feb 13, 2018
commit e047cb051c18e3bde623a9ec920700584f5e2b0e
2 changes: 1 addition & 1 deletion test/cctest/test_environment.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ TEST_F(EnvironmentTest, AtExitWithEnvironment) {
TEST_F(EnvironmentTest, AtExitWithoutEnvironment) {
const v8::HandleScope handle_scope(isolate_);
const Argv argv;
Env env {handle_scope, argv, this};
Env env {handle_scope, argv};

AtExit(at_exit_callback1); // No Environment is passed to AtExit.
RunAtExit(*env);
Expand Down