Skip to content

net: use _final instead of on('finish') #18608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

net: use _final instead of on('finish') #18608

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a09c1a
net: use `_final` instead of `on('finish')`
addaleax Feb 7, 2018
845bf1d
[squash] nit
addaleax Feb 7, 2018
356ac44
[squash] add streams-only test
addaleax Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[squash] nit
  • Loading branch information
@addaleax
addaleax committed Feb 20, 2018
commit 845bf1d62e6761d3a2f0e47e62a47838738e4161
2 changes: 1 addition & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ function shutdownSocket(self, callback) {
// the user has called .end(), and all the bytes have been
// sent out to the other side.
Socket.prototype._final = function(cb) {
// If still connecting - defer handling 'finish' until 'connect' will happen
// If still connecting - defer handling `_final` until 'connect' will happen
if (this.connecting) {
debug('_final: not yet connected');
return this.once('connect', () => this._final(cb));
Expand Down