Skip to content

src: do not redefine private for GenDebugSymbols #18653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

src: do not redefine private for GenDebugSymbols #18653

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cce09c3
src: do not redefine private for GenDebugSymbols
joyeecheung Feb 8, 2018
b56fc10
squash! remove unnecessary std lib includes
joyeecheung Feb 8, 2018
b37013c
squash! remove unnecessary forward declaration
joyeecheung Feb 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash! remove unnecessary forward declaration
  • Loading branch information
@joyeecheung
joyeecheung committed Feb 8, 2018
commit b37013cd5a618185ec5a05154ca60de34baaa366
2 changes: 0 additions & 2 deletions src/base_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@

namespace node {

int GenDebugSymbols();

class Environment;

class BaseObject {
Expand Down
2 changes: 0 additions & 2 deletions src/env.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ struct nghttp2_rcbuf;

namespace node {

int GenDebugSymbols();

namespace performance {
class performance_state;
}
Expand Down
2 changes: 0 additions & 2 deletions src/handle_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@

namespace node {

int GenDebugSymbols();

class Environment;

// Rules:
Expand Down
2 changes: 0 additions & 2 deletions src/req_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@

namespace node {

int GenDebugSymbols();

template <typename T>
class ReqWrap : public AsyncWrap {
public:
Expand Down
2 changes: 0 additions & 2 deletions src/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@

namespace node {

int GenDebugSymbols();

// These should be used in our code as opposed to the native
// versions as they abstract out some platform and or
// compiler version specific functionality
Expand Down