Skip to content

fs,net: emitting ready event for fs streams and network sockets in addition… #19408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sameer-coder wants to merge 5 commits into from
Closed

fs,net: emitting ready event for fs streams and network sockets in addition… #19408

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
204d89d
fs,net: emitting ready for fs streams and network sockets in addition…
sameer-coder Mar 17, 2018
01ee0db
fs,net: removed file descriptor for ready event and updated test case
sameer-coder Mar 21, 2018
e93c869
fs,net: removed file descriptor for ready event (writestream)
sameer-coder Mar 21, 2018
0778b58
fs,net: updated test case to check for ready event on writestream
sameer-coder Mar 21, 2018
008474a
fs,net: Fixed linter errors in test/parallel/test-fs-ready-event-stre…
sameer-coder Mar 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fs,net: updated test case to check for ready event on writestream 
updated test case updated test case to check for ready event
on writestream

Fixes: #19304
  • Loading branch information
@sameer-coder
sameer-coder committed Mar 21, 2018
commit 0778b5866510d04312da97881b701e73e6d6c750
12 changes: 10 additions & 2 deletions test/parallel/test-fs-ready-event-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@

'use strict';
const common = require('../common');
const fs = require('fs');
const assert = require('assert');
const path = require('path');
const tmpdir = require('../common/tmpdir');

const file = fs.createReadStream(__filename);
const readStream = fs.createReadStream(__filename);
readStream.on('ready', common.mustCall(() => {}, 1));

file.on('ready', common.mustCall(() => {}, 1));
const writeFile = path.join(tmpdir.path, 'write-fsreadyevent.txt');
tmpdir.refresh();
let writeStream = fs.createWriteStream(writeFile, { autoClose: true });
writeStream.on('ready', common.mustCall(() => {}, 1));