Skip to content

tools: add log output to crashes #20295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

tools: add log output to crashes #20295

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85d5145
tools: add log output to crashes
BridgeAR Apr 25, 2018
21ab0bc
fixup: address comment
BridgeAR Apr 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: add log output to crashes
  • Loading branch information
@BridgeAR
BridgeAR committed Apr 25, 2018
commit 85d5145fb8d18e5096967a77c9f714b1e1d076a4
2 changes: 1 addition & 1 deletion tools/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ def HasRun(self, output):
if output.HasCrashed():
self.severity = 'crashed'
exit_code = output.output.exit_code
self.traceback = "oh no!\nexit code: " + PrintCrashed(exit_code)
self.traceback += "oh no!\nexit code: " + PrintCrashed(exit_code)

@refack refack Apr 27, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO best solution is to drop this whole line and the prev line.

  • L290 will set the exit code (it's new code)
  • L300 will indicate crash

@BridgeAR BridgeAR Apr 27, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree because the exit code would not be visible in that case anymore. You are right.


if output.HasTimedOut():
self.severity = 'fail'
Expand Down