Skip to content

lib: reduce startup time #20567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 20 commits into from
Closed

lib: reduce startup time #20567

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
35cc355
string_decoder: lazy loaded
BridgeAR May 6, 2018
d480b63
querystring: lazy loaded
BridgeAR May 6, 2018
5c144fa
readline: lazy loaded
BridgeAR May 6, 2018
a18174b
os: lazy loaded
BridgeAR May 6, 2018
02c3b4b
dns: lazy loaded
BridgeAR May 6, 2018
9168e15
bootstrap: only load inspector stuff if necessary
BridgeAR May 6, 2018
1dfa4ec
esm: lazy load necessary loaders
BridgeAR May 6, 2018
246ab38
cluster: remove obsolete array allocation
BridgeAR May 6, 2018
e8ae9a4
trace_events: lazy loaded
BridgeAR May 6, 2018
ce21afd
lib: use capital letters in comments
BridgeAR May 7, 2018
a093ed3
bootstrap: remove unnecessary require
BridgeAR May 7, 2018
4733c2a
tools: stricter eslint rule for globals
BridgeAR May 7, 2018
e0080ce
assert,util: lazy load comparison functions
BridgeAR May 7, 2018
bd96a9d
async_hook: lazy loading for startup performance
BridgeAR May 7, 2018
d31581f
bootstrap: do not call performance hooks
BridgeAR May 7, 2018
0093e0d
stream: lazy load ReadableAsyncIterator
BridgeAR May 7, 2018
0b31adc
console: lazy load cli
BridgeAR May 7, 2018
5c3a245
stream: lazy load end-of-stream
BridgeAR May 7, 2018
b0bbbba
net: lazy load dns
BridgeAR May 7, 2018
3ca0b58
test: add loaded modules test
BridgeAR May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dns: lazy loaded
  • Loading branch information
@BridgeAR
BridgeAR committed May 14, 2018
commit 02c3b4b154e053a262e6fc16083c76089930293c
9 changes: 6 additions & 3 deletions lib/dgram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const {
ERR_SOCKET_DGRAM_NOT_RUNNING
} = errors.codes;
const { Buffer } = require('buffer');
const dns = require('dns');
const util = require('util');
const { isUint8Array } = require('internal/util/types');
const EventEmitter = require('events');
Expand All @@ -47,6 +46,9 @@ const { UV_UDP_REUSEADDR } = process.binding('constants').os;

const { UDP, SendWrap } = process.binding('udp_wrap');

// Lazy load for startup performance.
let dns;

const BIND_STATE_UNBOUND = 0;
const BIND_STATE_BINDING = 1;
const BIND_STATE_BOUND = 2;
Expand All @@ -72,9 +74,10 @@ function lookup6(lookup, address, callback) {


function newHandle(type, lookup) {
if (lookup === undefined)
if (lookup === undefined) {
if (dns === undefined) dns = require('dns');
lookup = dns.lookup;
else if (typeof lookup !== 'function')
} else if (typeof lookup !== 'function')
throw new ERR_INVALID_ARG_TYPE('lookup', 'Function', lookup);

if (type === 'udp4') {
Expand Down