Skip to content

assert: provide extra context in case of failed error validation checks #28263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 10 commits into from
Closed

assert: provide extra context in case of failed error validation checks #28263

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
75e5ba1
assert: improve class instance errors
BridgeAR Jun 13, 2019
f90cfca
assert: fix generatedMessage property
BridgeAR Jun 14, 2019
4d29fd1
assert: wrap validation function errors
BridgeAR Jun 14, 2019
1563d9d
assert: DRY .throws code
BridgeAR Jun 14, 2019
9d7d103
assert: add more information to AssertionErrors
BridgeAR Jun 15, 2019
adb44d3
assert: special handle identical error names in instance checks
BridgeAR Jun 15, 2019
e096890
doc: update assert.throws() examples
BridgeAR Jun 17, 2019
fa0f3f1
doc: update assert.throws example
BridgeAR Jun 17, 2019
683e311
doc: make `AssertionError` a link
BridgeAR Jun 20, 2019
9832d3d
fixup: doc: update assert.throws example
BridgeAR Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assert: fix generatedMessage property 
This makes sure the `generatedMessage` property is always set as
expected. This was not the case some `assert.throws` and
`assert.rejects` calls.
  • Loading branch information
@BridgeAR
BridgeAR committed Jun 15, 2019
commit f90cfca8f1ea4922122dc95582678e9f52e138c4
13 changes: 10 additions & 3 deletions lib/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,14 +573,21 @@ function expectedException(actual, expected, message, fn) {
if (expected.test(str))
return;

throw new AssertionError({
if (!message) {
generatedMessage = true;
message = 'The input did not match the regular expression ' +
`${inspect(expected)}. Input:\n\n${inspect(str)}\n`;
}

const err = new AssertionError({
actual,
expected,
message: message || 'The input did not match the regular expression ' +
`${inspect(expected)}. Input:\n\n${inspect(str)}\n`,
message,
operator: fn.name,
stackStartFn: fn
});
err.generatedMessage = generatedMessage;
throw err;
}

// Handle primitives properly.
Expand Down