Skip to content

stream: fix broken pipeline error propagation #31835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

stream: fix broken pipeline error propagation #31835

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f07a2d1
stream: fix broken pipeline error propagation
ronag Feb 21, 2020
86f40d3
fixup: don't call end if destroyed
ronag Feb 22, 2020
f4a1245
Update test/parallel/test-stream-pipeline-uncaught.js
ronag Feb 22, 2020
40c0b13
fixup: nits
ronag Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: nits
  • Loading branch information
@ronag
ronag committed Feb 22, 2020
commit 40c0b13c90ad5d394e137851a6ecd0f49becd376
6 changes: 3 additions & 3 deletions test/parallel/test-stream-pipeline-uncaught.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ const {
const assert = require('assert');

process.on('uncaughtException', common.mustCall((err) => {
assert.strictEqual(err.message, 'asd');
assert.strictEqual(err.message, 'error');
}));

// Ensure that pipeline that ends with Promise
// still propagates error to uncaughtException.
const s = new PassThrough();
s.end('asd');
s.end('data');
pipeline(s, async function(source) {
for await (const chunk of source) {
chunk;
}
}, common.mustCall((err) => {
assert.ifError(err);
throw new Error('asd');
throw new Error('error');
}));