Skip to content

src: initialize inspector before RunBootstrapping() #32672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

src: initialize inspector before RunBootstrapping() #32672

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4ce0133
src: initialize inspector before RunBootstrapping()
addaleax Apr 5, 2020
9cf8279
fixup! src: initialize inspector before RunBootstrapping()
addaleax Apr 5, 2020
8d2a588
fixup! src: initialize inspector before RunBootstrapping()
addaleax Apr 5, 2020
0ce07e3
fixup! src: initialize inspector before RunBootstrapping()
addaleax Apr 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: initialize inspector before RunBootstrapping()
  • Loading branch information
@addaleax
addaleax committed Apr 5, 2020
commit 0ce07e3e57577bb202b5c22552cd176c883898de
9 changes: 3 additions & 6 deletions src/node_worker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ void Worker::Run() {
std::move(argv_),
std::move(exec_argv_),
EnvironmentFlags::kNoFlags,
thread_id_));
thread_id_,
std::move(inspector_parent_handle_)));
if (is_stopped()) return;
CHECK_NOT_NULL(env_);
env_->set_env_vars(std::move(env_vars_));
Expand All @@ -328,12 +329,8 @@ void Worker::Run() {
{
CreateEnvMessagePort(env_.get());
Debug(this, "Created message port for worker %llu", thread_id_.id);
if (LoadEnvironment(env_.get(),
StartExecutionCallback{},
std::move(inspector_parent_handle_))
.IsEmpty()) {
if (LoadEnvironment(env_.get(), StartExecutionCallback{}).IsEmpty())
return;
}

Debug(this, "Loaded environment for worker %llu", thread_id_.id);
}
Expand Down