Skip to content

async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabled #33347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

async_hooks,worker: fix process.exit() crashes in async fn with async_hook enabled #33347

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b523a31
worker: call CancelTerminateExecution() before exiting Locker
addaleax May 10, 2020
d90c3d1
async_hooks: clear async_id_stack for terminations in more places
addaleax May 11, 2020
7b45371
test: regression tests for async_hooks + Promise + Worker interaction
addaleax May 10, 2020
3d9d564
fixup! test: regression tests for async_hooks + Promise + Worker inte…
addaleax May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: regression tests for async_hooks + Promise + Worker inte… 
…raction

Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@addaleax @cjihrig
addaleax and cjihrig authored May 11, 2020
commit 3d9d564db7b9b33f0fe0f66e5dc7e59b621f9705
2 changes: 1 addition & 1 deletion test/parallel/test-async-hooks-worker-asyncfn-terminate-3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const common = require('../common');
const { Worker } = require('worker_threads');

// Like test-async-hooks-worker-promise.js but with an additrional statement
// Like test-async-hooks-worker-promise.js but with an additional statement
// after the `process.exit()` call, that shouldn’t really make a difference
// but apparently does.

Expand Down