Skip to content

events: variable originalListener is useless #33596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fuxingZhang wants to merge 1 commit into from
Closed

events: variable originalListener is useless #33596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
events: variable originalListener is useless
  • Loading branch information
@fuxingZhang
fuxingZhang committed May 28, 2020
commit 4664b0b1212404499ace92932070f0ca76a35a4d
5 changes: 1 addition & 4 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,6 @@ EventEmitter.prototype.prependOnceListener =
// Emits a 'removeListener' event if and only if the listener was removed.
EventEmitter.prototype.removeListener =
function removeListener(type, listener) {
let originalListener;

checkListener(listener);

const events = this._events;
Expand All @@ -474,7 +472,6 @@ EventEmitter.prototype.removeListener =

for (let i = list.length - 1; i >= 0; i--) {
if (list[i] === listener || list[i].listener === listener) {
originalListener = list[i].listener;
position = i;
break;
}
Expand All @@ -495,7 +492,7 @@ EventEmitter.prototype.removeListener =
events[type] = list[0];

if (events.removeListener !== undefined)
this.emit('removeListener', type, originalListener || listener);
this.emit('removeListener', type, listener);
}

return this;
Expand Down