Skip to content

http2: add maxHeaderSize option to http2 #33636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
preyunk wants to merge 7 commits into from
Closed

http2: add maxHeaderSize option to http2 #33636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
984132d
http2: add maxHeaderSize option to http2
preyunk May 29, 2020
3ba02da
test: add tests for maxHeaderSize setting in http2
preyunk May 29, 2020
205f38a
http2: added more tests for maxHeaderSize
preyunk May 29, 2020
2f3782c
http2: fixed linting issues
preyunk May 29, 2020
5857ca5
http2: fixed failing tests
preyunk May 30, 2020
8f6c4aa
http2: added doc for maxHeaderSize
preyunk May 31, 2020
2a506c8
http2: maxHeaderSize overwrites maxHeaderListSize
preyunk Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http2: add maxHeaderSize option to http2 
add maxHeaderSize to http2 as an alias for maxHeaderListSize.

Fixes: #33517
  • Loading branch information
@preyunk
preyunk committed May 29, 2020
commit 984132d2bec75abd278718eb9fc584e53430ff00
5 changes: 4 additions & 1 deletion lib/internal/http2/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,9 @@ const validateSettings = hideStackFrames((settings) => {
assertWithinRange('maxHeaderListSize',
settings.maxHeaderListSize,
0, kMaxInt);
assertWithinRange('maxHeaderSize',
settings.maxHeaderSize,
0, kMaxInt);
if (settings.enablePush !== undefined &&
typeof settings.enablePush !== 'boolean') {
throw new ERR_HTTP2_INVALID_SETTING_VALUE('enablePush',
Expand Down Expand Up @@ -3112,7 +3115,7 @@ function getUnpackedSettings(buf, options = {}) {
settings.maxFrameSize = value;
break;
case NGHTTP2_SETTINGS_MAX_HEADER_LIST_SIZE:
settings.maxHeaderListSize = value;
settings.maxHeaderListSize = settings.maxHeaderSize = value;
break;
case NGHTTP2_SETTINGS_ENABLE_CONNECT_PROTOCOL:
settings.enableConnectProtocol = value !== 0;
Expand Down
20 changes: 17 additions & 3 deletions lib/internal/http2/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,13 @@ function getDefaultSettings() {

if ((flags & (1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE)) ===
(1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE)) {
holder.maxHeaderListSize =
holder.maxHeaderListSize = holder.maxHeaderSize =
settingsBuffer[IDX_SETTINGS_MAX_HEADER_LIST_SIZE];
}
if ((flags & (1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE)) ===
(1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE)) {
holder.maxHeaderSize = settingsBuffer[IDX_SETTINGS_MAX_HEADER_LIST_SIZE];
}
Comment thread
preyunk marked this conversation as resolved.
Outdated

if ((flags & (1 << IDX_SETTINGS_ENABLE_CONNECT_PROTOCOL)) ===
(1 << IDX_SETTINGS_ENABLE_CONNECT_PROTOCOL)) {
Expand All @@ -322,6 +326,7 @@ function getSettings(session, remote) {
maxFrameSize: settingsBuffer[IDX_SETTINGS_MAX_FRAME_SIZE],
maxConcurrentStreams: settingsBuffer[IDX_SETTINGS_MAX_CONCURRENT_STREAMS],
maxHeaderListSize: settingsBuffer[IDX_SETTINGS_MAX_HEADER_LIST_SIZE],
maxHeaderSize: settingsBuffer[IDX_SETTINGS_MAX_HEADER_LIST_SIZE],
enableConnectProtocol:
!!settingsBuffer[IDX_SETTINGS_ENABLE_CONNECT_PROTOCOL]
};
Expand Down Expand Up @@ -349,10 +354,19 @@ function updateSettingsBuffer(settings) {
settingsBuffer[IDX_SETTINGS_MAX_FRAME_SIZE] =
settings.maxFrameSize;
}
if (typeof settings.maxHeaderListSize === 'number') {
if (typeof settings.maxHeaderListSize === 'number' ||
typeof settings.maxHeaderSize === 'number') {
flags |= (1 << IDX_SETTINGS_MAX_HEADER_LIST_SIZE);
if (settings.maxHeaderSize && settings.maxHeaderListSize) {
if (settings.maxHeaderSize !== settings.maxHeaderListSize) {
Comment thread
preyunk marked this conversation as resolved.
Outdated
throw new ERR_HTTP2_INVALID_SETTING_VALUE.RangeError(
'maxHeaderListSize', settings.maxHeaderListSize
Comment thread
preyunk marked this conversation as resolved.
Outdated
);
}
}
Comment thread
himself65 marked this conversation as resolved.
settingsBuffer[IDX_SETTINGS_MAX_HEADER_LIST_SIZE] =
settings.maxHeaderListSize;
settings.maxHeaderListSize !== undefined ?
settings.maxHeaderListSize : settings.maxHeaderSize;
}
if (typeof settings.enablePush === 'boolean') {
flags |= (1 << IDX_SETTINGS_ENABLE_PUSH);
Expand Down