Skip to content

Allow passing FileHandle objects via postMessage #33772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 11 commits into from
Closed

Allow passing FileHandle objects via postMessage #33772

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cbc35c3
src: introduce BaseObject base FunctionTemplate
addaleax Apr 8, 2020
915b90e
worker: allow transferring/cloning generic BaseObjects
addaleax Apr 9, 2020
5f25ff9
fixup! worker: allow transferring/cloning generic BaseObjects
addaleax Jun 6, 2020
b1aad92
src: add equality operators for BaseObjectPtr
addaleax Jun 6, 2020
877d631
worker: allow passing JS wrapper objects via postMessage
addaleax Jun 6, 2020
758fe1a
worker,fs: make FileHandle transferable
addaleax Jun 6, 2020
82a2220
fixup! worker: allow passing JS wrapper objects via postMessage
addaleax Jun 6, 2020
22e70e2
fixup! worker,fs: make FileHandle transferable
addaleax Jun 6, 2020
c74eeb2
fixup! fixup! worker: allow passing JS wrapper objects via postMessage
addaleax Jun 6, 2020
a94759a
fixup! worker,fs: make FileHandle transferable
addaleax Jun 7, 2020
9f487ab
worker: emit `'messagerror'` events for failed deserialization
addaleax Jun 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: add equality operators for BaseObjectPtr
  • Loading branch information
@addaleax
addaleax committed Jun 11, 2020
commit b1aad92c98d8c909c93971b47c2b12c32f2a0a6f
14 changes: 14 additions & 0 deletions src/base_object-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,20 @@ BaseObjectPtrImpl<T, kIsWeak>::operator bool() const {
return get() != nullptr;
}

template <typename T, bool kIsWeak>
template <typename U, bool kW>
bool BaseObjectPtrImpl<T, kIsWeak>::operator ==(
const BaseObjectPtrImpl<U, kW>& other) const {
return get() == other.get();
}

template <typename T, bool kIsWeak>
template <typename U, bool kW>
bool BaseObjectPtrImpl<T, kIsWeak>::operator !=(
const BaseObjectPtrImpl<U, kW>& other) const {
return get() != other.get();
}

template <typename T, typename... Args>
BaseObjectPtr<T> MakeBaseObject(Args&&... args) {
return BaseObjectPtr<T>(new T(std::forward<Args>(args)...));
Expand Down
5 changes: 5 additions & 0 deletions src/base_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,11 @@ class BaseObjectPtrImpl final {
inline T* operator->() const;
inline operator bool() const;

template <typename U, bool kW>
inline bool operator ==(const BaseObjectPtrImpl<U, kW>& other) const;
template <typename U, bool kW>
inline bool operator !=(const BaseObjectPtrImpl<U, kW>& other) const;

private:
union {
BaseObject* target; // Used for strong pointers.
Expand Down