Skip to content

stream: cleanup and fix Readable.wrap #34204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

stream: cleanup and fix Readable.wrap #34204

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03e4964
stream: cleanup and fix Readable.wrap
ronag Jul 4, 2020
7f91aa4
fixup
ronag Jul 4, 2020
c2e7f03
fixup
ronag Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@ronag
ronag committed Jul 6, 2020
commit c2e7f03acb3a76d9a8ba0c90393143afebeacc31
6 changes: 1 addition & 5 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,11 +1047,7 @@ Readable.prototype.wrap = function(stream) {
// Proxy all the other methods. Important when wrapping filters and duplexes.
for (const i of ObjectKeys(stream)) {
if (this[i] === undefined && typeof stream[i] === 'function') {
this[i] = function methodWrap(method) {
return function methodWrapReturnFunction() {
return stream[method].apply(stream, arguments);
};
}(i);
this[i] = stream[i].bind(stream);
}
}

Expand Down