Skip to content

doc: document security issues with url.parse() #34226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

doc: document security issues with url.parse() #34226

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
061d486
doc: document security issues with url.parse()
jasnell Jul 6, 2020
b7eaab8
[Squash] suggestion
jasnell Jul 7, 2020
81a9ae6
[squash] nits
jasnell Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] nits 
Co-authored-by: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@jasnell @Trott
jasnell and Trott authored Jul 9, 2020
commit 81a9ae6d093f44da4010734d5976ceadabb57ffe
10 changes: 5 additions & 5 deletions doc/api/url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1262,11 +1262,11 @@ A `TypeError` is thrown if `urlString` is not a string.

A `URIError` is thrown if the `auth` property is present but cannot be decoded.

Use of the legacy `url.parse()` method is not recommended. All users should
migrate to the WHATWG `URL` api. Because the `url.parse()` method uses a
Use of the legacy `url.parse()` method is discouraged. Users should
use the WHATWG `URL` API. Because the `url.parse()` method uses a
lenient, non-standard algorithm for parsing URL strings, security
issues can be introduced. Specifically, issues with [hostname spoofing][] and
incorrect handling of user info (usernames and passwords) have been identified.
issues can be introduced. Specifically, issues with [host name spoofing][] and
incorrect handling of usernames and passwords have been identified.

### `url.resolve(from, to)`
<!-- YAML
Expand Down Expand Up @@ -1385,7 +1385,7 @@ console.log(myURL.origin);
[WHATWG URL Standard]: https://url.spec.whatwg.org/
[WHATWG URL]: #url_the_whatwg_url_api
[examples of parsed URLs]: https://url.spec.whatwg.org/#example-url-parsing
[hostname spoofing]: https://hackerone.com/reports/678487
[host name spoofing]: https://hackerone.com/reports/678487
[legacy `urlObject`]: #url_legacy_urlobject
[percent-encoded]: #whatwg-percent-encoding
[stable sorting algorithm]: https://en.wikipedia.org/wiki/Sorting_algorithm#Stability