Skip to content

stream: try to wait for flush to complete before 'finish' #34314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: try to wait for flush to complete before 'finish' #34314

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0391515
stream: try to wait for flush to complete before 'finish'
ronag Jul 11, 2020
0e5a7d5
fixup
ronag Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@ronag
ronag committed Jul 11, 2020
commit 0e5a7d549f1e49f65914c292d56a3b2246c59cfa
5 changes: 5 additions & 0 deletions lib/zlib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,11 @@ ZlibBase.prototype._flush = function(callback) {
this._transform(Buffer.alloc(0), '', callback);
};

// Force Transform compat behavior.
ZlibBase.prototype._final = function(callback) {
callback();
Comment thread
ronag marked this conversation as resolved.
};

// If a flush is scheduled while another flush is still pending, a way to figure
// out which one is the "stronger" flush is needed.
// This is currently only used to figure out which flush flag to use for the
Expand Down